<html>
<head><meta charset="utf-8"><title>Properly adding features and feature flags · general · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/index.html">general</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Properly.20adding.20features.20and.20feature.20flags.html">Properly adding features and feature flags</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="201599034"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Properly%20adding%20features%20and%20feature%20flags/near/201599034" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Poliorcetics <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Properly.20adding.20features.20and.20feature.20flags.html#201599034">(Jun 22 2020 at 12:28)</a>:</h4>
<p>I recently made some PR that added feature flags ( <a href="https://github.com/rust-lang/rust/issues/73139">#73139</a> - merged, <a href="https://github.com/rust-lang/rust/issues/72717">#72717</a> - open)</p>



<a name="201599045"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Properly%20adding%20features%20and%20feature%20flags/near/201599045" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Poliorcetics <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Properly.20adding.20features.20and.20feature.20flags.html#201599045">(Jun 22 2020 at 12:28)</a>:</h4>
<p>And I discovered this today: <a href="https://rustc-dev-guide.rust-lang.org/implementing_new_features.html">https://rustc-dev-guide.rust-lang.org/implementing_new_features.html</a></p>



<a name="201599062"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Properly%20adding%20features%20and%20feature%20flags/near/201599062" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Poliorcetics <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Properly.20adding.20features.20and.20feature.20flags.html#201599062">(Jun 22 2020 at 12:28)</a>:</h4>
<p>as well as the two following pages (1.9 and 1.10)</p>



<a name="201599093"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Properly%20adding%20features%20and%20feature%20flags/near/201599093" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Poliorcetics <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Properly.20adding.20features.20and.20feature.20flags.html#201599093">(Jun 22 2020 at 12:29)</a>:</h4>
<p><a href="https://rustc-dev-guide.rust-lang.org/stability.html">https://rustc-dev-guide.rust-lang.org/stability.html</a><br>
<a href="https://rustc-dev-guide.rust-lang.org/stabilization_guide.html">https://rustc-dev-guide.rust-lang.org/stabilization_guide.html</a></p>



<a name="201599145"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Properly%20adding%20features%20and%20feature%20flags/near/201599145" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Poliorcetics <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Properly.20adding.20features.20and.20feature.20flags.html#201599145">(Jun 22 2020 at 12:29)</a>:</h4>
<p>I seem to have missed a lot of things, especially adding the feature flags to <a href="https://github.com/rust-lang/rust/blob/master/src/librustc_feature/active.rs">https://github.com/rust-lang/rust/blob/master/src/librustc_feature/active.rs</a></p>



<a name="201599189"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Properly%20adding%20features%20and%20feature%20flags/near/201599189" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Poliorcetics <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Properly.20adding.20features.20and.20feature.20flags.html#201599189">(Jun 22 2020 at 12:30)</a>:</h4>
<p>should I do it ? (As in: should I make a PR adding the relevant things if no one noticed it when I made the PRs ?)</p>



<a name="201601342"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Properly%20adding%20features%20and%20feature%20flags/near/201601342" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthew Jasper <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Properly.20adding.20features.20and.20feature.20flags.html#201601342">(Jun 22 2020 at 12:54)</a>:</h4>
<p><code>active.rs</code> is for language features, not library features. You should create a tracking issue for the unstable features though.</p>



<a name="201602365"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Properly%20adding%20features%20and%20feature%20flags/near/201602365" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Poliorcetics <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Properly.20adding.20features.20and.20feature.20flags.html#201602365">(Jun 22 2020 at 13:03)</a>:</h4>
<p>ohhhh, ok !</p>
<blockquote>
<p>You should create a tracking issue for the unstable features though.</p>
</blockquote>
<p>Done, either the PR itself has become the issue or a tracking issue has been created already <span aria-label="slight smile" class="emoji emoji-1f642" role="img" title="slight smile">:slight_smile:</span></p>



<a name="201645190"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Properly%20adding%20features%20and%20feature%20flags/near/201645190" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Properly.20adding.20features.20and.20feature.20flags.html#201645190">(Jun 22 2020 at 18:45)</a>:</h4>
<p><span class="user-mention" data-user-id="307289">@Poliorcetics</span> still create an issue. It takes a while for features to be stabilised if they are, and not having an issue makes it really hard to track it. Create an issue and link it to the (merged) pr and that should be fine</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>